feat(WhereUI): welcome users to their live region - #309
Merged
Conversation
…gion # Conflicts: # Where/WhereUI/Sources/Primary/LocationsView.swift
kyleve
commented
Sep 7, 2026
kyleve
added a commit
that referenced
this pull request
Sep 7, 2026
> _Posted by an AI agent on kve's behalf._ ## Summary - Reconcile all 12 area backlogs with source through PR #311 (`5f65b9f0`), including PR #309 that the previous report's stated source coverage missed. The inbox is empty. - Archive three entries: shipped logged-in/out scope modeling, shipped local ingest/manual-sample fan-out, and the corrected WhereCore documentation cluster. Keep the summary, picker, and other partially implemented work open. - File two welcome follow-ups: foreground lookup refresh and scrolling/modal snapshot coverage. Narrow the current-location marker request to what remains after the welcome feature. - Correct overstated failure claims, moved citations, test/reference counts, and snapshot backlog formatting. Document actual reconciliation and snapshot-model-sharing limitations. - Refresh `MODULE_AUDIT.md` with the commit boundary, module checks, and a derived inventory: 709 source files, 371 test/support files, 49 image-suite files, 495 references, and 25 test bundles. ## Review focus - The welcome foreground finding follows from the retained view's unchanged task key; its entry explicitly calls for a device reproduction before choosing the final trigger. No runtime fix is claimed here. - Snapshot model sharing remains open even though its misleading documentation is corrected. Priorities are preserved. - The September 9 benchmark-plan downgrade remains a saved deadline, not freshly verified billing state. The benchmark repository still exists and is not archived. ## Verification - `./swiftformat --lint` — passed; 0/1,136 files require formatting, 125 skipped. The sandbox initially prevented writing the optional formatter cache; lint itself passed. - `./shellcheck` — passed. - `./attribution --check` — passed; 12 credits current. - `./snapshot-shards check` — passed; 49 suites assigned 13/15/18 plus 3 intake. - `./sync-agents` — passed after instruction changes; generated files remain ignored. - `git diff --check` — passed. Both Swift diffs contain comments only. - `./test`, architecture execution, simulator/image suites, and retained Python/Ruby suites were skipped: this change contains Markdown and comments only, with no executable, reference-image, matrix, or rendered-copy changes. No fresh visual or live-motion validation is claimed. The automation's Linux/static-analysis limitations are preserved; this run used macOS host checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Locations tab did not acknowledge when Where began counting recorded days toward the user's current region. The new card makes that transition visible and provides a direct path to planning the rest of the stay without creating a second planning workflow. The Appearance switch keeps that acknowledgement optional.
Review focus
PlannedStayEditor, remains absent when planning is disabled, and waits for the welcome exit animation before presenting the sheet.Testing
./test WhereCoreTests WhereUITests --no-generate— 1,085 tests passed../test --only 'WhereCoreTests/WherePreferencesTests' --only 'WhereUITests/YearReportModelTests' --only 'WhereUITests/LocationWelcomeModelTests' --only 'WhereUITests/SettingsSearchTests' --no-generate— 55 tests passed../test --snapshots --only 'WhereUISnapshotTests/AppearanceSettingsViewSnapshotTests' --only 'WhereUISnapshotTests/LocationsViewSnapshotTests' --record never --review --no-build --no-generate --skip-architecture— 2 tests passed; all changed references were visually reviewed across light, dark, increased-contrast, VoiceOver-annotation, and large Dynamic Type variants../swiftformat --lint./sf-symbols --lint./xcstrings --lintgit diff --check